chore(vscode): use unjs/unbuild for bundling#4998
chore(vscode): use unjs/unbuild for bundling#4998kermanx wants to merge 33 commits intovuejs:masterfrom
unjs/unbuild for bundling#4998Conversation
kermanx
requested review from
KazariEX,
davidmatter,
johnsoncodehk,
so1ve and
zhiyuanzmj
as code owners
vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
vue-tsc
@vue/language-service
@vue/typescript-plugin
commit: |
kermanx
changed the title
unjs/unbuild for bundling
|
Hey, what do you think about switching to tsdown, powered by Rolldown, for faster speed? |
…uce bundle size (vuejs#5054) Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>
johnsoncodehk
force-pushed
the
master
branch
2 times, most recently
from
ae194a1 to
940b97c
Compare
…language-tools into chore/use-unbuild
… chore/use-unbuild
| "esbuild": "latest", | ||
| "esbuild-visualizer": "latest", | ||
| "reactive-vscode": "^0.2.9", | ||
| "rollup-plugin-visualizer": "^5.12.0", |
There was a problem hiding this comment.
I noticed that you've replaced sonda with rollup-plugin-visualizer. I will not try to convince you to use sonda, but if this was a technical decision, could you share the reason? I would appreciate your feedback so I can improve it.
There was a problem hiding this comment.
Hi @filipsobol, first of all thank you for developing sonda. One of the reasons is that we want the PR to keep the most relevant changes so that it has a greater chance of being merged. Another reason is that the output file treemap is paginated in Sonda, and we cannot visually check whether the modules that need to be shared by multiple files have been correctly split.
There was a problem hiding this comment.
Thank you, this gives me some interesting ideas 🤔
Another reason is that the output file treemap is paginated in Sonda, and we cannot visually check whether the modules that need to be shared by multiple files have been correctly split.
By visual check, do you mean manual or automated visual check? You should be able to switch between chunks using the dropdown menu in the upper-left corner, but I can imagine that it may require extra work or even problems in automated tests (e.g. if it visually compares two reports).
johnsoncodehk
force-pushed
the
master
branch
3 times, most recently
from
c3e80dc to
209717c
Compare
KazariEX
force-pushed
the
master
branch
2 times, most recently
from
5ae4b38 to
d782f70
Compare
5 participants
Use https://github.com/unjs/unbuild to bundle the VSCode extension, also as a preparation for #4994.
Notes:
pnpm dev:vue, the command will exit after the stub files generated (no need to watch file changes), then F5. (Should the tasks defined in.vscode/tasks.jsonand.vscode/launch.jsonbe restored?)